-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(network): introducing Ktor interceptor #272
Conversation
srtvprateek
commented
Sep 12, 2023
- Ktor interceptor introduced
- Custom interceptor exposed
* feat: ktor interceptor * address review comments * ktlint * address review comments * Update build.gradle --------- Co-authored-by: Prateek <[email protected]>
* refactor & fixes * refactor * removed need to add base module as dependency * code restructure * refactor * refactor * move CacheDirectoryProvider to okhttp module * PlutoInterceptor refactored * refactor * PlutoKtorInterceptor refactored * access modifier fixed * gradle fixes * access modifier fixed * mock setting in ktor interceptor * refactor * publish config fixes * removed old custom interceptor logic * data field cleanup * init * content type fix * query param incorrect data fix * sample code refactor * fix(pluto): missing no-op methods added (#271) * fix(pluto): missing no-op methods added * pending fix * added core no-op * renaming
f8423b1
to
54b0d87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits, overall Looks good!
...plugins/network/core/lib-no-op/src/main/java/com/pluto/plugins/network/PlutoNetworkPlugin.kt
Outdated
Show resolved
Hide resolved
@@ -24,8 +24,9 @@ import com.pluto.utilities.share.Shareable | |||
import com.pluto.utilities.share.lazyContentSharer | |||
import com.pluto.utilities.spannable.setSpan | |||
import com.pluto.utilities.viewBinding | |||
import io.ktor.http.Url | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I used the Ktor url here is that it is multiplatform. not sure is this should be avoided since this dependency will go to people not using ktor as well :/.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is ok,
this is part of core module.